^
Login

or


Development Notes

You are viewing an older version of this article from 2018-04-16
Go to current version

1. Introduction



Over the years of developing Xu-Fu's Pet Guide, many ideas and suggestions accumulated. I have tried a few different tools like Trello or even Confluence to keep track of them together with my development notes, but these tools are way too clunky for this small project. And they all lack transparency.
This section aims to solve both problems: all my notes in one place, and making them visible to you, the hopefully curious reader!

You will find this article changing constantly. If a feature or bug suddenly vanishes from this list, it usually means that it weng live :-)

2. Bugs


- Wailing Critters => Pet table when not logged in shows different pets than when logged in. Why!?
- PO file on Home.php => title for "Article creators" is hardcoded
- message when comment reaches gold status working or not?
- gold comment trigger will trigger email in the language of that person who made the deciding upvote. Not the person who made the comment. com_vote in ajax
- in profiles, btag and discord can be way too long. needs a way to display it properly
asdf




3. Project: Battletable 2.0 (40%)


The battle tables were the first thing created on Xu-Fu. They are mostly static and not up to the standards of the current page.
This project is to fully re-create them, to integrate the user system, user collections and to add many more features.

3.1 Info


Logic of substitute finder:
no requirements => all substitutes are fine, based on skills and family
only a breed => creator pet, only show the selected breed(s). For substitutes, ignore breeds
only a stat => use the stat to determine which creator pet breed is OK. and use the stat for substitutes and their breeds
breed and stats => for the creators pet, only show the breed he activated. for substitutes, use the stat to show them or not.

3.2 Open Tasks


- Required breed output:
> if only 1 breed is possible, format so the lone commata is not visible - code marker btbr01
> create tooltip showing all possible breeds and which ones are OK to use, which ones are NOK

- check against collection and output it graphically:
> show owned pets under "Your pet":
If 1: "Yes - HB"
If more: "Yes (2)" with tooltip.

> test if owned pet does NOT meet requirements (breed, level etc.) and output orangy border
> make the border around the whole pet card, not just the lighter part (include column left)
> check if border colors work with every family color background

- Rematch strings
> Store pet IDs and breed strings somewhere hidden for all 3 pets.
> When changing substitute, have the content changed and have the rematch string changed accordingly with the data stored in those hidden fields



- level pet slot

- Star rating tooltip needs a single "star" icon
- An option in user settings to select the priority of strategies, which order is more important, maybe tags to exclude entirely so they never show up?
- strategies pull info from Pets database, need to move to PetsUser and PetsNPC
- URLs in creator text are not formatted correctly https://wow-petguide.com/index.php?Strategy=1218
- Recreate additional info section (see UI draft)
- question mark with breeds to show breed info, which breeds are available for this pet, and which ones you own, if they are verified for this strategy or not and why not.
- add interactivity to above tooltips to rate breeds and gather info from users if a certain breed worked or not
- in case no breed fits the requirements, show some kind of info text about it.
- update print_pettable to use the new logic for substitutes. "Any Fox" etc. doesn't exist anymore then.

3.3 Known Bugs


- Tooltip of favourite button not positioned correctly

3.4 Optional features


- Counter for how many visits a strategy has received
- "My Strategies" page for strat creators. show # visits, comments, votes and favs of own strategies.
- Info section explaining how everything work

3.5 Release plan


- check if functions check_specialpet and get_specialpet are still required and kill them if not
- give every strategy a user as creator
- remove all votes /ratings from strategies
- move all "Any Fox" etc. to direct pets
- remove "Any Fox" etc. entries from PetsUser DB
- thanks to Grainne and Remte and everyone else who helped with the substitute finder
- give thanks to Simca for the breed info from petbattle breed ID
- give thanks to the creator of the pet xp thread for the info: https://www.warcraftpets.com/community/forum/viewtopic.php?t=8829




4. Project: Clever Alternatives (0%)


The strategy alternatives should not have a limit. They should not have a fixed order. The order should be dynamic and follow a logic that could include user settings, pets collected, strategy upvotes, favourits and additional factors.
The interface should use AJAX and give a clearer preview of the pets used.





5. Project: User Strategies (0%)


Users should be able to create and add their own strategies.




6. Project: Pet Cards (0%)


Basically, replace wowhead tooltips with xu-fu pet tooltips that show more value (breeds, stats etc.)




7. Project: Blog 2.0 (0%)


The blog should support different topics and different users posting updates. The blog should be sortable by topic / date. It should show a quick overview and should be searchable. There should be the option to go to a single blog post and view that in full screen.




8. Miscellaneous Tasks, Bugs and Suggestions



8.1 Suggestions


By Irayna: Add XP Values to link list on left (like EU/US appearances of Menagerie). To see which fights give more XP than usual (espcially for legion world quests)
By Flatluigi: 21.03.2018: minor sort of request: for the pets that don't have a level/can't battle, take them out of the calculations for number of pets at max level/at rare quality
By Remte: I'd like to have fresh comment responses notifications cleared out when I visit them independently.
By Panseit: message system, put an icon next to the user profile icon when new messages are there.
By Irayna: When viewing other peoples collection, add a column for your own pets to compare the collections.


8.2 Tasks and To-Dos


- add protocol entries to admin pages
- Petimport - adm_petimport.php:
- check at beginning if user pets are not verified with "cageable or not" and go through them.
- user pets: option to set cageable or not
- Spells: entire API import missing
- battle tag in user profiles needs EU / US switch
- my comments section sometimes does not filter the comments correctly
- option to claim old comments
- crawl of pet collection: if a character is saved, use that one. If that saved char is not available anymore, crawl all characters from bnet again and pick most recently active one and save that one.




9. Possible Future Projects


- SEO
- comment-section: show more info about the threads in tooltip? maybe the top comment + 2 or 3 additional ones with [..] and a "X more messages" ?
- comment-section: for "Votes", maybe add together all votes from the thread from your comments? Otherwise a +50 subcomment might be hidden because it's not the first one
- Email notifications
- Tools: Top X pets of all strategies
- "Your profile has been viewed X times."
- Add friend (what effects?)
- specific user icons and backgrounds for admins / mods /translators
- sticky comments
- user setting how many comments to display per page (currently set site wide)
- better brute force protection (pw reset)
- rework all tooltips to use tooltipster
- comment moderation features directly on page, including display of reports
- allow bnet connected accounts to unlink from bnet
- comment statistics (how many, how often per month, average upvotes etc.)
- Flavour growls:
"your collection was updated and you got these new pets in the last week!"
after X days of registration, still no password / battle.net connected - send reminder message "hey do this for x"




10. Finished Projects



10.1 Project: Article Editor (100%)


The page hosts many different articles and supports localization into 9 languages. This editor makes it easy for other users to add, edit or translate articles.
It is fully integrated into the user system, UAC, and allows on-page editing.



19 Comments (EN)

Show first:


You must be logged in to vote on comments

0

You must be logged in to vote on comments

Wh15k3y_ wrote on 09/27/2020

when i try to login, no window appears. just all screen faded. how can i login now?
You must be logged in to vote on comments

1

You must be logged in to vote on comments

Aranesh

wrote on 09/27/2020

There was an error on the webpage. It should be all back to normal now. Sorry for that!
You must be logged in to vote on comments

0

You must be logged in to vote on comments

Beardsly wrote on 09/07/2020

Forgive me if I missed it, Will there be a Rematch and TDbattle scripts functional during Prepatch/Shadowlands? While I see mass exporting isn't a thing, will there at least be a functional addon to put in the updated strats? Thank you for all that you do.
You must be logged in to vote on comments

1

You must be logged in to vote on comments

Shenk

wrote on 09/07/2020

there already is a version for rematch working in SL. tdscript is being worked on
You must be logged in to vote on comments

1

You must be logged in to vote on comments

Aranesh

wrote on 09/07/2020

The Mass Rematch tool mentioned here is not going to happen before Shadowlands, but there is a mass rematch export already possible for each section :)
Just go to a section and hit the blue Load Pet Table button - once loaded, a rematch export button is available
You must be logged in to vote on comments

1

You must be logged in to vote on comments

Thoizor

wrote on 06/20/2020

My collection doesn't get updated properly. Here it says I have 539 pets at max level, and 25 uncommon pets, while when checking my collection on warcraftpets website it tells me I have 555 at max level and 18 uncommon pets. Any idea why it's like this? I use the same char for updating both profiles.

EDIT: Am leveling battle pets atm, so the numbers mentioned above are no longer correct. There does remain a difference of 16 pets at max level between both sites, as well as a difference of 7 uncommon pets. (edited)
You must be logged in to vote on comments

1

You must be logged in to vote on comments

CoJo

wrote on 06/17/2020

The hyperlinks to the legion quests in the new Powerleveling widget don't work.
You must be logged in to vote on comments

1

You must be logged in to vote on comments

Aranesh

wrote on 06/17/2020

Working for me, which one exactly and where does it lead you to?
You must be logged in to vote on comments

2

You must be logged in to vote on comments

Gráinne

wrote on 06/17/2020

I get

Sir Galveston https://wow-petguide.com/8361
Jarrun https://wow-petguide.com/5043

Ahhh. US vs EU.

I had the US page up when I saw those. On EU I get the right pages. (edited)
You must be logged in to vote on comments

1

You must be logged in to vote on comments

CoJo

wrote on 06/18/2020

Any link from the widget sends me to what appears to be a 404 page in German. Would also like to mention that last night, the widget's date was off as well for me. It was showing the date as the 17th when it was still the 16th here in the US. As Grainne said, it probably has problems between EU/US.
You must be logged in to vote on comments

1

You must be logged in to vote on comments

Aranesh

wrote on 06/18/2020

Aaah found it!
Both of these should be fixed now :) Thanks for bringing it up!
You must be logged in to vote on comments

1

You must be logged in to vote on comments

WalkingDead11

wrote on 04/04/2020

love the site and want to submit my bug report. I am not sure where to post this bug report so this post might need to be moved or removed. Here is my problem: When I am looking at a strategy on my touch screen device, in Google Chrome for Android 80.0.3987.162 and click on the alternatives. A menu comes up, but if there are too many alternatives on the menu I cannot scroll down the list. If I try to scroll down it reacts to the first touch and immediately closes the menu even if I press directly on the scroll bar. It does the same thing even if I request the desktop site version in my browser.Very annoying because I cannot see all the alternatives. Thank you. (edited)
You must be logged in to vote on comments

2

You must be logged in to vote on comments

Aranesh

wrote on 04/04/2020

Hey! Absolutely the right place for this type of feedback :)

The sad but simple answer, though, is: There is no mobile version of the page. It was never designed to support mobile :/ I try to make tweaks here and there but lack the knowledge (and time) to make it really mobile friendly.
I'll log a bug ticket for me to look into the alternatives tab a bit more, maybe I can come up with a solution. Thanks for reporting it and sorry I don't have a better answer for you!
You must be logged in to vote on comments

1

You must be logged in to vote on comments

Shenk

wrote on 04/04/2020

it's not like i haven't annoyed him before with it. glad i'm not the only one now ;)
You must be logged in to vote on comments

2

You must be logged in to vote on comments

Gráinne

wrote on 04/04/2020

I'm honestly bemused by requests for mobile-friendliness in this context.

The only time these strats are useful is when you are actually at your PC. Why would people use a mobile browser when sitting at their keyboard? What's the condition I'm not seeing?
You must be logged in to vote on comments

1

You must be logged in to vote on comments

Shenk

wrote on 04/04/2020

changing/working on your strategies and strategy curating in general
You must be logged in to vote on comments

1

You must be logged in to vote on comments

DragonsAfterDark

wrote on 04/04/2020

Some people also don't like to alt + tab if they only have one monitor. I know for me, half the time I don't remember what I was looking at when I move to a different screen. Imagine trying to do some of the strats on here, and alt-tabbing for each step.
You must be logged in to vote on comments

1

You must be logged in to vote on comments

Shenk

wrote on 04/04/2020

ok boomer
You must be logged in to vote on comments

1

You must be logged in to vote on comments

Gráinne

wrote on 04/04/2020

I don't have to imagine; that's what I do when I'm checking a strat out. (I really should bring down my second monitor and find the adaptor and set it up again.) What I can't imagine is the awkwardness of trying to use a phone screen instead. But OK, if people do that, then they do, I guess.
You must be logged in to vote on comments

1

You must be logged in to vote on comments

Shenk

wrote on 04/04/2020

when i'm not at home during the week (which is usually the case if not for the current quarantine stuff) and not always have access to a pc or tablet i'm sometimes forced to do strategy reworking on my phone... and that really isn't pleasant at all
You must be logged in to vote on comments

2

You must be logged in to vote on comments

Aranesh

wrote on 04/05/2020

Only thing I can say to that is: Sorry!
I'm in the very, very early stages of learning how to do mobile friendliness :/
You must be logged in to vote on comments

1

You must be logged in to vote on comments

Blocky

wrote on 01/14/2020

Hi, are you aware of a bug that is effecting the site's Export Team feature? The error message below seems to be injecting itself into the export, also every line now includes a BR HTML tag in addition to newline markup tag.

Error messages:

This error message: "Use of undefined constant language - assumed 'language' (this will throw an Error in a future version of PHP) in /kunden/426045_85652/webseiten/Petguide/classes/ajax/bt_rmsteps.php on line 152

This error message: "Use of undefined constant language - assumed 'language' (this will throw an Error in a future version of PHP) in /kunden/426045_85652/webseiten/Petguide/classes/ajax/bt_rmsteps.php on line 179
You must be logged in to vote on comments

2

You must be logged in to vote on comments

Aranesh

wrote on 01/15/2020

This should be fixed, thanks for the heads-up!
You must be logged in to vote on comments

3

You must be logged in to vote on comments

Blocky

wrote on 01/16/2020

Yes it is fixed, hurrah! You are amazing!
You must be logged in to vote on comments

1

You must be logged in to vote on comments

Aranesh

wrote on 01/17/2020

<3
You must be logged in to vote on comments

1

You must be logged in to vote on comments

JestersTear

wrote on 12/05/2019

I don't know if something like this is possible, but a suggestion -

For the pet dungeons, instead of just spitting out the optimal strategy for each encounter based on our pet list, make a dungeon optimal strategy list all at once? What I mean is I look up, let's say, Gnomeregon, and it tells me for optimal strategies to use the same pet in 5 fights. Maybe something where it starts at the last fight and works backwards, so your best pets are used for the last fight (let's say it's fight #10), then it goes back to fight 9 and looks for an optimal strategy that doesn't use the 3 pets you'll be using in the final fight unless you have 2+ of one of them. This way you don't get to fight 8 and it says to use Ikky, but all 3 are either dead or too wounded from fights 2, 4 and 5 to be used again.
(edited)
You must be logged in to vote on comments

2

You must be logged in to vote on comments

Aranesh

wrote on 12/05/2019

Hey JestersTear!

That's definitely planned :) It's currenty listed as "Upcoming Project: New Dungeon Tool" and what you are suggesting is *exactly* what I'm planning to do ^^
Hope I'll be through this current database rework soon so I can jump on cooler stuff like this one.
Thanks for the suggestion! If you have any other ideas, always happy to hear them
You must be logged in to vote on comments

3

You must be logged in to vote on comments

JestersTear

wrote on 12/05/2019

Thanks, your hard work is definitely appreciated!
You must be logged in to vote on comments

1

You must be logged in to vote on comments

ZoroarkRonan

wrote on 09/08/2019

i have a question. when i was looking at my strat it said OP what does that mean?
You must be logged in to vote on comments

2

You must be logged in to vote on comments

Gráinne

wrote on 09/08/2019

OP = Original Poster, which as the poster of the strat, refers to you.
You must be logged in to vote on comments

1

You must be logged in to vote on comments

ragath

wrote on 05/20/2019

I would suggest GitHub or GitLab for maintaining and developing this project. These 2 tools are no overkil for this "small project" as you called it in the beginning. Both offer free code versioning for private repositories, Issue Tracking and more. Personally I prefer GitLab as it has more features.
You must be logged in to vote on comments

1

You must be logged in to vote on comments

Aranesh

wrote on 05/21/2019

Hey ragath!
I know about both and what they do, but have never used them to work on a software product. I'm very much a novice in this field and in the creation of this page I made many mistakes that make it very hard to move it to a repository, mostly security details (hardcoded passwords yay!). The effort to make everything ready for such a move is probably quite high, and a big unknown to me. So it's part not wanting to invest the time and part not wanting people to see the code behind this page that keeps me from doing it ^^'
You must be logged in to vote on comments

1

You must be logged in to vote on comments

ragath

wrote on 05/22/2019

I'm a professional software developer and I work with GitHub everyday. So in case you are interested in learnig how to get to a "new Level" I could give you some tips. With private repositories your code is not public and not visible to others. In case of hard-coded passwords and stuff there are simple methods how to handle it, e.g. using .env files or simple array files. But I also understand that it's a bit of work to migrate this project to GitLab etc
You must be logged in to vote on comments

1

You must be logged in to vote on comments

shybobcat

wrote on 03/20/2019

I’d like to report a bug, hope this is the right place. A linked group of similar crabs, starting with Kelp Scuttler, does not have their abilities aligned. For example, if the Kelp Scuttler is listed with the skills 1 1 2, when you scroll through the rest of the group, they are all listed as skills 2 2 2, while they should be the same as the first one. You can see it in this strategy:

https://www.wow-petguide.com/index.php?Strategy=1352

Would also like to add that this site is amazing! I’m very impressed with both how it looks and especially how well done the coding behind it! Thank you!
You must be logged in to vote on comments

2

You must be logged in to vote on comments

Remte

wrote on 03/20/2019

Thank you for your kind words :)
I reuploaded the pet and told our master tinkerer, and it seems it's okay now. Hopefully it was not a signal of something more severe ^^
You must be logged in to vote on comments

1

You must be logged in to vote on comments

shybobcat

wrote on 03/21/2019

Thank you for a quick fix! It works fine now :)
You must be logged in to vote on comments

2

You must be logged in to vote on comments

Ekire

wrote on 12/28/2018

Wondering - now that they changed the way pet battles work, would it be doable to add the pet trainer names in brackets beside the quest name? Not everyone knows the WQ name if it isnt up, but the trainer name is easy to reference.
You must be logged in to vote on comments

1

You must be logged in to vote on comments

Ekire

wrote on 12/30/2018

Meaning stuff like Family Battler - IE: Zuldazar quest for "Small Beginnings" - Show it as either "Zujai - Small Beginnings", or "Small Beginnings (Zujai)"
You must be logged in to vote on comments

1

You must be logged in to vote on comments

Remte

wrote on 12/06/2018

Not too soon: To avoid duplicates, any achievement-specific (Plushie, Family and as it was suggested The Longest Day) strategy could be automatically linked in the "global" encounter list (still redirecting to family section after clicking). To prevent clutter, they could be displayed only via user input to show more.
If this is not worth it, just expand the duplicate warning to all sections of the page… though it could be problem when someone decides to apply a strat the other way i.e. from globals to specific ones :P